RFR: 8284849: Add deoptimization to unified logging [v2]

Johan Sjölén duke at openjdk.java.net
Wed Jun 1 11:59:41 UTC 2022


On Tue, 31 May 2022 10:35:24 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> Johan Sjölén has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Change log to single line
>
> src/hotspot/share/runtime/deoptimization.cpp line 1939:
> 
>> 1937:       const char* reason_action = Deoptimization::trap_action_name(action);
>> 1938:       JFR_ONLY(post_deoptimization_event(nm, tm, trap_bci, trap_bc, reason, action);)
>> 1939:       if (Log(deoptimization)::is_info()) {
> 
> I don't think this `if` is needed now? The `log_debug` macro already seems to check whether the tag is enabled.

100% correct, it also checks the wrong log level so double whammy mistake right there.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8812


More information about the hotspot-dev mailing list