RFR: 8284849: Add deoptimization to unified logging [v3]

[Johan Sjölén]

On Tue, 7 Jun 2022 18:45:28 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Johan Sjölén has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove superfluous if stmt
>
> src/hotspot/share/runtime/deoptimization.cpp line 1937:
> 
>> 1935:       char* name_sig = tm->name_and_sig_as_C_string();
>> 1936:       const char* reason_name = Deoptimization::trap_reason_name(reason);
>> 1937:       const char* reason_action = Deoptimization::trap_action_name(action);
> 
> What is the reason to specify `Deoptimization::` in these calls?

Thanks, removed :-).

> src/hotspot/share/runtime/deoptimization.cpp line 1941:
> 
>> 1939:       log_debug(deoptimization)("cid: %d osr: %s level: %d %s @ %d %s -> %s",
>> 1940:                                 nm->compile_id(),
>> 1941:                                 (nm->is_osr_method() ? "true" : "false"),
> 
> Since it is one-liner it should follow how we print for `-Xlog:jit+compilation=debug`: 
> https://github.com/openjdk/jdk/blob/master/src/hotspot/share/compiler/compileTask.cpp#L482
> 
> [0.142s][debug][jit,compilation]    6 %     4       Reproducer::run @ 8 (39 bytes)
> 
> Of cause we can use `osr` instead of `%` in output to be clear.
> 
> You can simplify `osr: %s` print by `%s` and `(nm->is_osr_method() ? "osr" : "   ")`
> You also need to print `osr_bci` - we can have separate compilations of the same method for different `bci`.
> Also print `p2i(fr.pc())` and relative PC which very useful:
> https://github.com/openjdk/jdk/blob/master/src/hotspot/share/runtime/deoptimization.cpp#L1883

This is the current log line (w/o "osr"), it's become quite long.

`[12,240s][debug][deoptimization] cid=135  pc=0x00007fa4dcbef5d4 relative_pc=0x0000000000000154 level=4 java.util.concurrent.locks.ReentrantLock$Sync::tryRelease @ 26 unstable_if reinterpret`

I changed to `=` to make it consistent with the latter example you posted. `osr_bci` is added after the `trap_bci`. I also refactored logging into using `LogStream` in a separate method, but the common logging block is still inline.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8812