RFR: 8287071: Loom: Cleanup x86_64 gen_continuation_enter [v4]

[Patricio Chilano Mateo]

On Wed, 1 Jun 2022 15:09:07 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> During x86_32 porting, I ended up rewriting the copy of x86_64 gen_continuation_enter significantly to make it more streamlined. The original x86_64 gen_continuation_enter should enjoy the similar streamlining, since it would likely to be the template for many other architectures.
>> 
>> There might be more things to do, I would not know until x86_32 fully works. I am pretty sure current thing is self-sufficient.
>> 
>> Brief tour of changes:
>>  - Check the incoming registers explicitly
>>  - Pass explicit argument registers to `fill_continuation_entry`
>>  - Use the usual `NativeCall` alignment code to produce a patchable call
>>  - Check that static stub is emitted, fail hard otherwise
>>  - Handle register shuffling for `exception_handler_for_return_address` the similar way we do it in `StubGenerator`
>> 
>> Additional testing:
>>  - [x] Linux x86_64 fastdebug, prospective `jdk_loom hotspot_loom`
>
> Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains seven commits:
> 
>  - Merge branch 'master' into JDK-8287071-loom-x86-64-gen-cont-enter
>  - Merge branch 'master' into JDK-8287071-loom-x86-64-gen-cont-enter
>  - Harmonize exception handler invocation
>  - Merge branch 'master' into JDK-8287071-loom-x86-64-gen-cont-enter
>  - Merge branch 'master' into JDK-8287071-loom-x86-64-gen-cont-enter
>  - Revert test groups
>  - Fix

src/hotspot/cpu/x86/sharedRuntime_x86_64.cpp line 1276:

> 1274: static void gen_continuation_enter(MacroAssembler* masm,
> 1275:                                  const methodHandle& method,
> 1276:                                  const BasicType* sig_bt,

Should we remove these two parameters? They were used on a commented out line which is now removed.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8802