RFR: 8287071: Loom: Cleanup x86_64 gen_continuation_enter [v4]

Aleksey Shipilev shade at openjdk.java.net
Mon Jun 6 14:30:46 UTC 2022


On Mon, 6 Jun 2022 14:01:20 GMT, Patricio Chilano Mateo <pchilanomate at openjdk.org> wrote:

>> Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains seven commits:
>> 
>>  - Merge branch 'master' into JDK-8287071-loom-x86-64-gen-cont-enter
>>  - Merge branch 'master' into JDK-8287071-loom-x86-64-gen-cont-enter
>>  - Harmonize exception handler invocation
>>  - Merge branch 'master' into JDK-8287071-loom-x86-64-gen-cont-enter
>>  - Merge branch 'master' into JDK-8287071-loom-x86-64-gen-cont-enter
>>  - Revert test groups
>>  - Fix
>
> src/hotspot/cpu/x86/sharedRuntime_x86_64.cpp line 1276:
> 
>> 1274: static void gen_continuation_enter(MacroAssembler* masm,
>> 1275:                                  const methodHandle& method,
>> 1276:                                  const BasicType* sig_bt,
> 
> Should we remove these two parameters? They were used on a commented out line which is now removed.

Yes, we can. See new commit. I guess I should just test the `reg_cont_obj` explicitly instead of trying to call the generic `verify_oop_args`. New version passes `jdk_loom hotspot_loom` with `-XX:+VerifyOops`.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8802


More information about the hotspot-dev mailing list