RFR: 8288105: [PPC64] Problems with -XX:+VerifyStack [v3]

[Goetz Lindenmaier]

On Mon, 13 Jun 2022 10:31:18 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

>> Deoptimization and uncommon trap stubs require last Java PC to point to a PC which has an appropriate OopMap. Otherwise, -XX:+VerifyStack does no longer work after [JDK-8284161](https://bugs.openjdk.org/browse/JDK-8284161).
>> I had to debug through the frame stuff and I made the code a bit more robust and easier to use and debug.
>
> Martin Doerr has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Simplify frame(void* sp, void* fp, void* pc).

Marked as reviewed by goetz (Reviewer).

src/hotspot/cpu/ppc/frame_ppc.cpp line 397:

> 395: #ifndef PRODUCT
> 396: // This is a generic constructor which is only used by pns() in debug.cpp.
> 397: frame::frame(void* sp, void* fp, void* pc) : frame((intptr_t*)sp, (address)pc) {}

You might add a comment that fp is dropped intensionally.  Only a nice to have ...

-------------

PR: https://git.openjdk.org/jdk19/pull/3