RFR: 8288105: [PPC64] Problems with -XX:+VerifyStack [v3]

Martin Doerr mdoerr at openjdk.java.net
Mon Jun 13 12:41:30 UTC 2022


On Mon, 13 Jun 2022 11:27:40 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote:

>> Martin Doerr has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Simplify frame(void* sp, void* fp, void* pc).
>
> src/hotspot/cpu/ppc/frame_ppc.cpp line 397:
> 
>> 395: #ifndef PRODUCT
>> 396: // This is a generic constructor which is only used by pns() in debug.cpp.
>> 397: frame::frame(void* sp, void* fp, void* pc) : frame((intptr_t*)sp, (address)pc) {}
> 
> You might add a comment that fp is dropped intensionally.  Only a nice to have ...

Comment added. Thanks for the review!

-------------

PR: https://git.openjdk.org/jdk19/pull/3


More information about the hotspot-dev mailing list