RFR: 8288623: Move Continuation classes out of javaClasses.hpp [v3]

[Stefan Karlsson]

On Fri, 17 Jun 2022 15:21:07 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> javaClasses.hpp is getting too big - it contains the C++ representation of over 50 Java classes.
>> 
>> The RFE moves the following classes into a new file, continuationJavaClasses.hpp. The naming follows the same pattern as the existing header share/jvmci/jvmciJavaClasses.hpp.
>> 
>> - jdk_internal_vm_ContinuationScope
>> - jdk_internal_vm_Continuation
>> - jdk_internal_vm_StackChunk
>
> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fixed include guard macro and copyright year

src/hotspot/share/classfile/continuationJavaClasses.cpp line 28:

> 26: #include "classfile/javaClassesImpl.hpp"
> 27: #include "classfile/javaClasses.hpp"
> 28: #include "classfile/continuationJavaClasses.hpp"

Include order

src/hotspot/share/classfile/javaClassesImpl.hpp line 26:

> 24: 
> 25: #ifndef SHARE_CLASSFILE_JAVACLASSES_IMPL_HPP
> 26: #define SHARE_CLASSFILE_JAVACLASSES_IMPL_HPP

Convention is to name this:
SHARE_CLASSFILE_JAVACLASSESIMPL_HPP

src/hotspot/share/classfile/javaClassesImpl.hpp line 29:

> 27: 
> 28: #include "classfile/javaClasses.hpp"
> 29: #include "classfile/continuationJavaClasses.hpp"

Include order

src/hotspot/share/gc/g1/g1CollectedHeap.inline.hpp line 31:

> 29: 
> 30: #include "oops/stackChunkOop.hpp"
> 31: #include "gc/g1/g1BarrierSet.hpp"

Include order

-------------

PR: https://git.openjdk.org/jdk/pull/9191