RFR: 8288623: Move Continuation classes out of javaClasses.hpp [v3]

Stefan Karlsson stefank at openjdk.org
Fri Jun 17 20:22:55 UTC 2022


On Fri, 17 Jun 2022 15:21:07 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> javaClasses.hpp is getting too big - it contains the C++ representation of over 50 Java classes.
>> 
>> The RFE moves the following classes into a new file, continuationJavaClasses.hpp. The naming follows the same pattern as the existing header share/jvmci/jvmciJavaClasses.hpp.
>> 
>> - jdk_internal_vm_ContinuationScope
>> - jdk_internal_vm_Continuation
>> - jdk_internal_vm_StackChunk
>
> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fixed include guard macro and copyright year

I've talked to Ioi and Coleen about whether `javaClasses` or `continuations` should be the considered the most relevant subsystem. Their take is that `continuations` is. I'm warming up to that thought, but I think I'd then would prefer if continuationsJavaClasses.hpp etc. get moved to where the other continuation files are, in the runtime/ directory.

-------------

PR: https://git.openjdk.org/jdk/pull/9191


More information about the hotspot-dev mailing list