RFR: 8286446: PPC64: fix crashes after JDK-8284161 (virtual threads preview)

Richard Reingruber rrich at openjdk.java.net
Tue May 10 11:08:48 UTC 2022


On Tue, 10 May 2022 10:36:03 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

>> With this change `java -version` succeeds with the devkit build also the standard build on a ppc64le box does not crash anymore.
>> 
>> Also tier1 tests don't look too bad.
>
> src/hotspot/cpu/ppc/frame_ppc.inline.hpp line 106:
> 
>> 104:   // In thaw, non-heap frames use this constructor to pass oop_map.  I don't know why.
>> 105:   assert(_on_heap || _cb != nullptr, "these frames are always heap frames");
>> 106:   if (cb != NULL) {
> 
> Wouldn't usability be better without this check? (Call `setup()` regardless of `cb` provided or not.) Or is there any reason?

This ctor is currently not used. I simply copy'n'pasted the complete set of constructors. I'll remove it because a review without uses is hardly possible.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8617


More information about the hotspot-dev mailing list