RFR: 8286446: PPC64: fix crashes after JDK-8284161 (virtual threads preview)

Coleen Phillimore coleenp at openjdk.java.net
Tue May 10 12:15:48 UTC 2022


On Tue, 10 May 2022 10:53:34 GMT, Richard Reingruber <rrich at openjdk.org> wrote:

>> src/hotspot/share/runtime/signature.cpp line 265:
>> 
>>> 263:       _fp_args++;
>>> 264:     } else {
>>> 265:       PPC64_ONLY(_stack_arg_slots = align_up(_stack_arg_slots, 2));
>> 
>> Looks good. Alternatively, we could think about dropping alignment on PPC64, but I think such changes could be done later (improvements of other platforms may also be worth being discussed). Your version fits to the current PPC64 platform code.
>
> I'd agree

These ifdefs are fine but argues for making this code platform dependent.  not in this change though.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8617


More information about the hotspot-dev mailing list