RFR: JDK-8287288: Fix some typos in C1
David Holmes
dholmes at openjdk.java.net
Wed May 25 12:07:44 UTC 2022
On Wed, 25 May 2022 09:11:23 GMT, Zhuojun Miao <zmiao at openjdk.org> wrote:
> This is a trivial patch to fix some typos in C1.
> e.g. https://github.com/openjdk/jdk/blob/master/src/hotspot/share/c1/c1_LIRGenerator.cpp#L1190
These cleanups all look good except for one. I think that bit diagram needs checking.
Thanks.
David
src/hotspot/share/c1/c1_LIR.hpp line 203:
> 201: // data opr-type opr-kind
> 202: // +-----------+----------+-------+
> 203: // [max........|6 5 4 3|2 1 0]
I don't think your change is right. The code below indicates there are 3 bits for kind. So I think the original should actually look like this:
// data opr-type opr-kind
// +--------------+-------+--------+--+
// [max...........|7 6 5 4| 3 2 1 | 0]
-------------
Marked as reviewed by dholmes (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/8880
More information about the hotspot-dev
mailing list