RFR: JDK-8287288: Fix some typos in C1

Zhuojun Miao zmiao at openjdk.java.net
Thu May 26 02:18:41 UTC 2022


On Wed, 25 May 2022 12:02:37 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> This is a trivial patch to fix some typos in C1.
>> e.g. https://github.com/openjdk/jdk/blob/master/src/hotspot/share/c1/c1_LIRGenerator.cpp#L1190
>
> src/hotspot/share/c1/c1_LIR.hpp line 203:
> 
>> 201:   //     data      opr-type  opr-kind
>> 202:   // +-----------+----------+-------+
>> 203:   // [max........|6  5  4  3|2  1  0]
> 
> I don't think your change is right. The code below indicates there are 3 bits for kind. So I think the original should actually look like this:
> 
> 
> //     data       opr-type opr-kind
> // +--------------+-------+--------+--+
> // [max...........|7 6 5 4| 3 2 1  | 0]

According to the definitions of `Opr_kind` and `kind_mask` below, it can be seen that `opr-kind` uses the lowest 3 bits, and if the lowest bit is 0, it means that this is a pointer.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8880


More information about the hotspot-dev mailing list