RFR: 8295044: Implementation of Foreign Function and Memory API (Second Preview) [v2]

[Maurizio Cimadamore]

On Sat, 5 Nov 2022 18:04:38 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> Maurizio Cimadamore has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 17 additional commits since the last revision:
>> 
>>  - Merge branch 'master' into PR_20
>>  - Merge branch 'master' into PR_20
>>  - Merge pull request #14 from minborg/small-javadoc
>>    
>>    Update some javadocs
>>  - Update some javadocs
>>  - Revert some javadoc changes
>>  - Merge branch 'master' into PR_20
>>  - Fix benchmark and test failure
>>  - Merge pull request #13 from minborg/revert-factories
>>    
>>    Revert MemorySegment factories
>>  - Update javadocs after comments
>>  - Revert MemorySegment factories
>>  - ... and 7 more: https://git.openjdk.org/jdk/compare/1fd35b8a...3d933028
>
> src/java.base/share/classes/jdk/internal/foreign/abi/BindingSpecializer.java line 491:
> 
>> 489:         emitLoad(highLevelType, paramIndex2ParamSlot[paramIndex]);
>> 490: 
>> 491:         if (shouldAcquire(paramIndex)) {
> 
> I can't comment on the actual line below, but this is also missing the fix from: https://github.com/openjdk/panama-foreign/pull/739 (that is a Java-only change as well). I suggest adding that as well.

Few changes were missing - but the `dontrelease` tests was passing... odd

-------------

PR: https://git.openjdk.org/jdk/pull/10872