RFR: 8295044: Implementation of Foreign Function and Memory API (Second Preview) [v2]

[Maurizio Cimadamore]

On Sat, 5 Nov 2022 18:40:56 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> Maurizio Cimadamore has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 17 additional commits since the last revision:
>> 
>>  - Merge branch 'master' into PR_20
>>  - Merge branch 'master' into PR_20
>>  - Merge pull request #14 from minborg/small-javadoc
>>    
>>    Update some javadocs
>>  - Update some javadocs
>>  - Revert some javadoc changes
>>  - Merge branch 'master' into PR_20
>>  - Fix benchmark and test failure
>>  - Merge pull request #13 from minborg/revert-factories
>>    
>>    Revert MemorySegment factories
>>  - Update javadocs after comments
>>  - Revert MemorySegment factories
>>  - ... and 7 more: https://git.openjdk.org/jdk/compare/d8bb7119...3d933028
>
> src/java.base/share/classes/jdk/internal/foreign/abi/x64/windows/CallArranger.java line 165:
> 
>> 163:                 assert forArguments : "no stack returns";
>> 164:                 // stack
>> 165:                 long alignment = Math.max(layout.byteAlignment(), STACK_SLOT_SIZE);
> 
> This is also missing part of the changes from: https://github.com/openjdk/panama-foreign/pull/728/ but other changes to the shared code are present. The `layout` parameter is not needed here. (see the changes to this file in the original PR)

Actually, this patch is missing most of the stuff in PR 728. I was under the impression that, in order to fully support that, some VM changes were needed (e.g. to have better granularity in call shuffling - as per https://github.com/openjdk/panama-foreign/pull/699). As a result, this PR only contains changes to SharedUtil (to remove unused alignment functions) - but nothing else.

-------------

PR: https://git.openjdk.org/jdk/pull/10872