RFR: 8295711: Rename ZBarrierSetAssembler::load_at parameter name from "tmp_thread" to "tmp2"

Erik Österlund eosterlund at openjdk.org
Mon Nov 14 10:22:34 UTC 2022


On Thu, 20 Oct 2022 08:28:09 GMT, Fei Yang <fyang at openjdk.org> wrote:

> This is a trivial change renaming a formal parameter for ZBarrierSetAssembler::load_at.
> 
> On AArch64 and RISC-V, the last formal parameter for ZBarrierSetAssembler::load_at
> is named "tmp_thread". But the callers will pass an ordinary temporary register for
> this parameter which has no relation with the thread register. We should rename this
> formal parameter from "tmp_thread" to "tmp2".
> 
> Testing: fastdebug builds on linux-aarch64 & linux-riscv64.

The tmp_thread name came from the x86 port where there are places where the tmp_thread register can't be used arbitrarily, but rather is limited to contain the thread pointer, as there is no dedicated thread register on 32 bit x86. The name was copied to the other platforms and it never made sense. I'm happy with this cleanup. Looks good.

-------------

Marked as reviewed by eosterlund (Reviewer).

PR: https://git.openjdk.org/jdk/pull/10783


More information about the hotspot-dev mailing list