RFR: 8297445: PPC64: Represent Registers as values [v2]
Richard Reingruber
rrich at openjdk.org
Wed Nov 23 20:33:33 UTC 2022
On Wed, 23 Nov 2022 15:41:32 GMT, Richard Reingruber <rrich at openjdk.org> wrote:
>> Martin Doerr has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Update Copyright years.
>
> src/hotspot/cpu/ppc/register_ppc.hpp line 89:
>
>> 87: bool operator==(const Register rhs) const { return _encoding == rhs._encoding; }
>> 88: bool operator!=(const Register rhs) const { return _encoding != rhs._encoding; }
>> 89: const Register* operator->() const { return this; }
>
> This is clever! Personally I'd be in favor of removing it in a cleanup change for simplicity.
Ah, it's also used in shared code (e.g. FrameMap::regname()) so cleanup is only possible after all ports represent Registers as values.
-------------
PR: https://git.openjdk.org/jdk/pull/11297
More information about the hotspot-dev
mailing list