RFR: 8297445: PPC64: Represent Registers as values [v2]

Martin Doerr mdoerr at openjdk.org
Wed Nov 23 21:04:21 UTC 2022


On Wed, 23 Nov 2022 20:29:39 GMT, Richard Reingruber <rrich at openjdk.org> wrote:

>> src/hotspot/cpu/ppc/register_ppc.hpp line 89:
>> 
>>> 87:   bool operator==(const Register rhs) const { return _encoding == rhs._encoding; }
>>> 88:   bool operator!=(const Register rhs) const { return _encoding != rhs._encoding; }
>>> 89:   const Register* operator->() const { return this; }
>> 
>> This is clever! Personally I'd be in favor of removing it in a cleanup change for simplicity.
>
> Ah, it's also used in shared code (e.g. FrameMap::regname()) so cleanup is only possible after all ports represent Registers as values.

Correct. I think this should get done at some point of time.

-------------

PR: https://git.openjdk.org/jdk/pull/11297


More information about the hotspot-dev mailing list