RFR: 8297742: Combine vmTestbase/nsk/monitoring/ThreadMXBean/resetPeakThreadCount tests [v2]

[David Holmes]

On Tue, 29 Nov 2022 02:36:12 GMT, Alex Menkov <amenkov at openjdk.org> wrote:

>> The fix combines almost the same tests to 1 test to remove code duplication
>
> Alex Menkov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Used multiple test tags

Looks good - nice consolidation. One nit with some pre-existing badly worded text.

Thanks.

test/hotspot/jtreg/vmTestbase/nsk/monitoring/ThreadMXBean/resetPeakThreadCount/reset001.java line 37:

> 35:  *     that, resetPeakThreadCount() is invoked to reset the peak. Then
> 36:  *     getPeakThreadCount() and getThreadCount() must return the same values. The
> 37:  *     preposition is that no threads are appered/disappeared between

This does not read correctly even ignoring the typo in "appered" - suggestion:

> The expectation is that no threads are created, or terminate, between ...

And please also fix the same comment at lines 118/119

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.org/jdk/pull/11400