RFR: 8297742: Combine vmTestbase/nsk/monitoring/ThreadMXBean/resetPeakThreadCount tests [v2]
Alex Menkov
amenkov at openjdk.org
Tue Nov 29 08:48:22 UTC 2022
On Tue, 29 Nov 2022 04:34:22 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> Alex Menkov has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Used multiple test tags
>
> test/hotspot/jtreg/vmTestbase/nsk/monitoring/ThreadMXBean/resetPeakThreadCount/reset001.java line 37:
>
>> 35: * that, resetPeakThreadCount() is invoked to reset the peak. Then
>> 36: * getPeakThreadCount() and getThreadCount() must return the same values. The
>> 37: * preposition is that no threads are appered/disappeared between
>
> This does not read correctly even ignoring the typo in "appered" - suggestion:
>
>> The expectation is that no threads are created, or terminate, between ...
>
> And please also fix the same comment at lines 118/119
Done.
I'm not sure about commas (for me it's better without them)
Fixed here as you suggested and without commas in lines 118-119 :)
Please add a comment if you prefer consistency
-------------
PR: https://git.openjdk.org/jdk/pull/11400
More information about the hotspot-dev
mailing list