RFR: 8296470: Refactor VMError::report STEP macro to improve readability [v3]

[Axel Boldt-Christmas]

On Tue, 29 Nov 2022 11:35:42 GMT, Axel Boldt-Christmas <aboldtch at openjdk.org> wrote:

>> Refactor the STEP macro in VMError::report to improve readability.
>> Right now the macro contains multiple statements on one line and the non-conventional control flow is even harder to understand.
>> 
>> This enhancement aims to do two things:
>>  1. It splits the macro into multiple lines with indentations which makes the structure of the C++ code generated by the preprocessor clearer.
>>   2. Separates the internal step logic from the decision logic which decides if a step should be taken with a STEP_IF(step_name_str, condition) macro
>> 
>> Testing: tier 1 + GHA
>
> Axel Boldt-Christmas has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add newlines

No worries, thanks for the reviews.

-------------

PR: https://git.openjdk.org/jdk/pull/11018