Integrated: 8296470: Refactor VMError::report STEP macro to improve readability
Axel Boldt-Christmas
aboldtch at openjdk.org
Tue Nov 29 11:41:46 UTC 2022
On Mon, 7 Nov 2022 13:25:53 GMT, Axel Boldt-Christmas <aboldtch at openjdk.org> wrote:
> Refactor the STEP macro in VMError::report to improve readability.
> Right now the macro contains multiple statements on one line and the non-conventional control flow is even harder to understand.
>
> This enhancement aims to do two things:
> 1. It splits the macro into multiple lines with indentations which makes the structure of the C++ code generated by the preprocessor clearer.
> 2. Separates the internal step logic from the decision logic which decides if a step should be taken with a STEP_IF(step_name_str, condition) macro
>
> Testing: tier 1 + GHA
This pull request has now been integrated.
Changeset: 1301fb0b
Author: Axel Boldt-Christmas <aboldtch at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/1301fb0b5f998c9cf8bcd8a53e6a90d6ab5a7da9
Stats: 733 lines in 1 file changed: 169 ins; 297 del; 267 mod
8296470: Refactor VMError::report STEP macro to improve readability
Reviewed-by: stuefe, coleenp
-------------
PR: https://git.openjdk.org/jdk/pull/11018
More information about the hotspot-dev
mailing list