RFR: 8295060: Port PrintDeoptimizationDetails to UL
Johan Sjölen
jsjolen at openjdk.org
Wed Oct 12 08:37:13 UTC 2022
On Wed, 12 Oct 2022 00:01:31 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> Hi!
>>
>> This PR ports PrintDeoptimizationDetails to UL by mapping its output to debug level with tag deoptimization.
>
> src/hotspot/share/runtime/vframe.hpp line 113:
>
>> 111: virtual void print_value() const;
>> 112: virtual void print();
>> 113: void print_on(outputStream* st) const override;
>
> Unclear if this should also be virtual.
This is virtual, taken from `ResourceObj`. The `override` indicates this, I'm basing this on: https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rh-override
-------------
PR: https://git.openjdk.org/jdk/pull/10645
More information about the hotspot-dev
mailing list