RFR: 8295060: Port PrintDeoptimizationDetails to UL

David Holmes dholmes at openjdk.org
Thu Oct 13 02:35:05 UTC 2022


On Wed, 12 Oct 2022 08:33:12 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

>> src/hotspot/share/runtime/vframe.hpp line 113:
>> 
>>> 111:   virtual void print_value() const;
>>> 112:   virtual void print();
>>> 113:   void print_on(outputStream* st) const override;
>> 
>> Unclear if this should also be virtual.
>
> This is virtual, taken from `ResourceObj`. The `override` indicates this, I'm basing this on: https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rh-override

Thanks - missed that.

-------------

PR: https://git.openjdk.org/jdk/pull/10645


More information about the hotspot-dev mailing list