RFR: 8293488: Add EOR3 backend rule for aarch64 SHA3 extension

Hao Sun haosun at openjdk.org
Wed Oct 12 10:50:10 UTC 2022


On Fri, 23 Sep 2022 11:13:40 GMT, Bhavana Kilambi <bkilambi at openjdk.org> wrote:

> Arm ISA v8.2A and v9.0A include SHA3 feature extensions and one of those SHA3 instructions - "eor3" performs an exclusive OR of three vectors. This is helpful in applications that have multiple, consecutive "eor" operations which can be reduced by clubbing them into fewer operations using the "eor3" instruction. For example -
> 
> eor a, a, b
> eor a, a, c
> 
> can be optimized to single instruction - `eor3 a, b, c`
> 
> This patch adds backend rules for Neon and SVE2 "eor3" instructions and a micro benchmark to assess the performance gains with this patch. Following are the results of the included micro benchmark on a 128-bit aarch64 machine that supports Neon, SVE2 and SHA3 features -
> 
> 
> Benchmark               gain
> TestEor3.test1Int       10.87%
> TestEor3.test1Long      8.84%
> TestEor3.test2Int       21.68%
> TestEor3.test2Long      21.04%
> 
> 
> The numbers shown are performance gains with using Neon eor3 instruction over the master branch that uses multiple "eor" instructions instead. Similar gains can be observed with the SVE2 "eor3" version as well since the "eor3" instruction is unpredicated and the machine under test uses a maximum vector width of 128 bits which makes the SVE2 code generation very similar to the one with Neon.

test/hotspot/jtreg/compiler/vectorization/TestEor3AArch64.java line 38:

> 36:  * @summary Test EOR3 Neon/SVE2 instruction for aarch64 SHA3 extension
> 37:  * @library /test/lib /
> 38:  * @requires os.arch == "aarch64" & vm.cpu.features ~=".*sha3.*"

Suggestion:

 * @requires os.arch == "aarch64" & vm.cpu.features ~= ".*sha3.*"

nit: [style] it's better to have one extra space.

-------------

PR: https://git.openjdk.org/jdk/pull/10407


More information about the hotspot-dev mailing list