RFR: 8293488: Add EOR3 backend rule for aarch64 SHA3 extension [v2]

Bhavana Kilambi bkilambi at openjdk.org
Thu Oct 13 10:12:44 UTC 2022


On Wed, 12 Oct 2022 10:46:17 GMT, Hao Sun <haosun at openjdk.org> wrote:

>> Bhavana Kilambi has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Modified JTREG test to include feature constraints
>
> test/hotspot/jtreg/compiler/vectorization/TestEor3AArch64.java line 38:
> 
>> 36:  * @summary Test EOR3 Neon/SVE2 instruction for aarch64 SHA3 extension
>> 37:  * @library /test/lib /
>> 38:  * @requires os.arch == "aarch64" & vm.cpu.features ~=".*sha3.*"
> 
> Suggestion:
> 
>  * @requires os.arch == "aarch64" & vm.cpu.features ~= ".*sha3.*"
> 
> nit: [style] it's better to have one extra space.

@shqking  Thank you for the comments. I have made the suggested changes.

-------------

PR: https://git.openjdk.org/jdk/pull/10407


More information about the hotspot-dev mailing list