RFR: 8295270: RISC-V: Clean up and refactoring for assembler functions

Feilong Jiang fjiang at openjdk.org
Thu Oct 13 12:57:14 UTC 2022


On Thu, 13 Oct 2022 12:17:00 GMT, Fei Yang <fyang at openjdk.org> wrote:

> Witnessed that some high-level assember functions are placed in file assembler_riscv.hpp/cpp,
> such as 'movptr', 'li' and so on. These are macro-assembler functions which should be placed
> in macroAssembler_riscv.hpp/cpp. Meanwhile, we should also move load & store memory and
> control assembler functions from address of type 'address' / 'Address'.
> 
> Testing: Tier1 hotspot on HiFive Unmatched board {fastdebug, release}.

src/hotspot/cpu/riscv/macroAssembler_riscv.hpp line 678:

> 676:       Assembler::NAME(Rd, Rd, ((int32_t)offset << 20) >> 20);                                      \
> 677:     } else {                                                                                       \
> 678:       int32_t offset = 0;                                                                          \

It might be confusing that we have already defined `offset` in L673 with a different type.

-------------

PR: https://git.openjdk.org/jdk/pull/10697


More information about the hotspot-dev mailing list