RFR: 8295060: Port PrintDeoptimizationDetails to UL [v2]
Coleen Phillimore
coleenp at openjdk.org
Thu Oct 20 14:14:53 UTC 2022
On Thu, 20 Oct 2022 01:51:36 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> Johan Sjölen has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Fix review comments
>
> src/hotspot/share/runtime/vframe.cpp line 684:
>
>> 682: }
>> 683: void vframe::print_on(outputStream* st) const {
>> 684: _fr.print_value_on(st,NULL);
>
> I think this was changed in response to Coleens' comment. While I agree we are getting rid of `WizardMode` this PR is about `PrintDeoptimizationDetails` and this change seems unrelated to that (unless nothing else calls `vframe::print`?).
There's a couple other printing function that call vframe::print() so I think that should keep WizardMode on for now until the callers become UL converted.
I don't think the vframe::print_on() version should keep WizardMode since logging calls it with the verbose logging level (guessing this is true, please check!)
-------------
PR: https://git.openjdk.org/jdk/pull/10645
More information about the hotspot-dev
mailing list