RFR: 8295060: Port PrintDeoptimizationDetails to UL [v2]

[Johan Sjölen]

On Thu, 20 Oct 2022 14:12:47 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> src/hotspot/share/runtime/vframe.cpp line 684:
>> 
>>> 682: }
>>> 683: void vframe::print_on(outputStream* st) const {
>>> 684:   _fr.print_value_on(st,NULL);
>> 
>> I think this was changed in response to Coleens' comment. While I agree we are getting rid of `WizardMode` this PR is about `PrintDeoptimizationDetails` and this change seems unrelated to that (unless nothing else calls `vframe::print`?).
>
> There's a couple other printing function that call vframe::print() so I think that should keep WizardMode on for now until the callers become UL converted.
> I don't think the vframe::print_on() version should keep WizardMode since logging calls it with the verbose logging level (guessing this is true, please check!)

>You don't need the WizardMode guard here and in print_on. UL is supposed replace WizardMode and Verbose so the correct fix would be to elide it from print_on and only log using print_on when the logging level is logically equivalent to WizardMode (as you have done elsewhere).

It was actually in response to what you said :-). I'm OK with either way.

-------------

PR: https://git.openjdk.org/jdk/pull/10645