RFR: 8293188: x86_64: Introduce stubGenerator_x86_64.hpp

[David Holmes]

On Wed, 31 Aug 2022 23:07:24 GMT, Vladimir Ivanov <vlivanov at openjdk.org> wrote:

> Introduce stubGenerator_x86_64.hpp and extract StubGenerator class declaration there. 
> 
> Testing: hs-tier1 - hs-tier4

Rather tricky to review  but as long as things build okay this should be fine. I'm assuming the motivation here was just to get smaller files to work with?

A couple of minor nits.

Thanks.

src/hotspot/cpu/x86/stubGenerator_x86_64.cpp line 51:

> 49: #include "jfr/support/jfrIntrinsics.hpp"
> 50: #endif
> 51: #include "stubGenerator_x86_64.hpp"

This should be in alphabetical order prior to the conditional includes.

src/hotspot/cpu/x86/stubGenerator_x86_64.hpp line 2:

> 1: /*
> 2:  * Copyright (c) 2022, Oracle and/or its affiliates. All rights reserved.

As the content of this file has been moved from another, the original file's copyright years should be preserved. Thanks.

src/hotspot/cpu/x86/stubGenerator_x86_64.hpp line 24:

> 22:  *
> 23:  */
> 24: 

Do we need the usual header file include guard?

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.org/jdk/pull/10111