RFR: 8293188: x86_64: Introduce stubGenerator_x86_64.hpp [v2]

Vladimir Ivanov vlivanov at openjdk.org
Thu Sep 1 16:43:27 UTC 2022


On Thu, 1 Sep 2022 04:52:19 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Vladimir Ivanov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   update
>
> src/hotspot/cpu/x86/stubGenerator_x86_64.cpp line 51:
> 
>> 49: #include "jfr/support/jfrIntrinsics.hpp"
>> 50: #endif
>> 51: #include "stubGenerator_x86_64.hpp"
> 
> This should be in alphabetical order prior to the conditional includes.

Fixed.

> src/hotspot/cpu/x86/stubGenerator_x86_64.hpp line 2:
> 
>> 1: /*
>> 2:  * Copyright (c) 2022, Oracle and/or its affiliates. All rights reserved.
> 
> As the content of this file has been moved from another, the original file's copyright years should be preserved. Thanks.

Fixed.

> src/hotspot/cpu/x86/stubGenerator_x86_64.hpp line 24:
> 
>> 22:  *
>> 23:  */
>> 24: 
> 
> Do we need the usual header file include guard?

Good point. Fixed.

-------------

PR: https://git.openjdk.org/jdk/pull/10111


More information about the hotspot-dev mailing list