RFR: 8293351: Add second tmp register to aarch64 BarrierSetAssembler::load_at [v4]

Tue Sep 6 12:06:42 UTC 2022

On Tue, 6 Sep 2022 10:49:06 GMT, Stuart Monteith <smonteith at openjdk.org> wrote:

>> Axel Boldt-Christmas has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Make tmp register names consistent g1BarrierSetAssembler_aarch64
>
> src/hotspot/cpu/aarch64/gc/g1/g1BarrierSetAssembler_aarch64.cpp line 277:
> 
>> 275:                          dst /* pre_val */,
>> 276:                          rthread /* thread */,
>> 277:                          tmp1 /* tmp */,
> 
> For tmp1 and tmp2 the comments, to match the paramter names, would also be "/* tmp1 */" and "/* tmp2 */".

Fixed 👍

> src/hotspot/cpu/aarch64/gc/g1/g1BarrierSetAssembler_aarch64.cpp line 301:
> 
>> 299:                        rthread /* thread */,
>> 300:                        tmp1  /* tmp */,
>> 301:                        rscratch2  /* tmp */,
> 
> "tmp1 /* tmp1 */," and "rscratch2 /* tmp2 */," to match the signature argument names.

Fixed 👍

-------------

PR: https://git.openjdk.org/jdk/pull/10161