RFR: 8294087: RISC-V: RVC: Fix a potential alignment issue and add more alignment assertions for the patchable calls/nops [v5]

Xiaolin Zheng xlinzheng at openjdk.org
Thu Sep 22 03:20:51 UTC 2022


On Thu, 22 Sep 2022 02:04:27 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> Xiaolin Zheng has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix a plural form typo in one comment
>
> src/hotspot/cpu/riscv/macroAssembler_riscv.cpp line 101:
> 
>> 99:   assert(is_aligned(pc, alignment), "bad alignment");
>> 100: }
>> 101: 
> 
> Would you mind a few more tweaks?
> I don't think we need two versions here. Maybe we can only keep the second one and remove the first one here?
> Then the call sites will look more consistent passing an explict 'pc' argument.
> Also we should move the function definition to macroAssembler_riscv.hpp.

Of course, revised and add `static inline void` for it in the hpp file.

-------------

PR: https://git.openjdk.org/jdk/pull/10370


More information about the hotspot-dev mailing list