RFR: 8294211: Zero: Decode arch-specific error context if possible [v2]
Thomas Stuefe
stuefe at openjdk.org
Thu Sep 22 19:16:19 UTC 2022
On Thu, 22 Sep 2022 19:03:28 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
>> Yes. I don't want to copy-paste the whole arch-specific code into this file. The bare minimum to have reasonable `hs_err`-s should do :)
>
> I forgot to mention why I do this. If we leave `ShouldNotCallThis()` here, then error handler does a secondary fault in these methods, and `hs_err` prints errors in these sections. So the deal here is removing the risky secondary fault -- I see no reason for it -- rather than printing out more info. When we can do that easily, like in the TOS and PC sections, we do.
Sure, makes sense to avoid them. Secondary crashes also build up stack, therefore they are limited to only a few before error handling just stops.
-------------
PR: https://git.openjdk.org/jdk/pull/10397
More information about the hotspot-dev
mailing list