RFR: JDK-8293711: Factor out size parsing functions from arguments.cpp [v2]
Thomas Stuefe
stuefe at openjdk.org
Fri Sep 23 14:12:26 UTC 2022
On Fri, 23 Sep 2022 14:04:54 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:
> > > is the new version acceptable?
> >
> >
> > I would have preferred if the parsing code were not placed in a .hpp file, and would have placed it in a .inline.hpp file, to comply with our guidelines. Other than that, I'm OK with this patch.
>
> Almost missed your comment :-)
>
> I'll split it up as you suggested, then push.
Wait, since the whole thing is all parsing, would that not mean we have just a parseInteger.inline.hpp, without a parseInteger.hpp? Since I'm unsure what would be left to put into parseInteger.hpp. And a parseInteger.inline.hpp without a parseInteger.hpp makes not much sense, or?
We have some other one-trick-pony-headers that are not .inline and contain their whole functionality: powerOfTwo.hpp, population_count.hpp (probably should rename that), pair.hpp...
-------------
PR: https://git.openjdk.org/jdk/pull/10252
More information about the hotspot-dev
mailing list