RFR: 8294293: Remove unused _width and _newlines field in outputStream [v2]

[Johan Sjölen]

On Mon, 26 Sep 2022 08:11:53 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Johan Sjölen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove include
>
> src/hotspot/share/utilities/ostream.cpp line 904:
> 
>> 902:   if (has_log_file()) {
>> 903:     int nl0 = _newlines;
>> 904:     xmlTextStream::write(s, len);
> 
> xmlTextStream::write seems to be unused after this change.

It does seem that way. The `outputStream::write` method is the function which all subclasses of `outputStream` implements, so we shouldn't remove this function without removing `xmlTextStream`. That's probably a separate RFE, and perhaps not desirable as it'd require merging the class into  `defaultStream`.

> src/hotspot/share/utilities/ostream.hpp line 32:
> 
>> 30: #include "utilities/globalDefinitions.hpp"
>> 31: #include "utilities/macros.hpp"
>> 32: #include <cstdint>
> 
> This std header doesn't seem to be used anywhere else in hotspot code - why do we need it here?

Good catch, it's been removed.

-------------

PR: https://git.openjdk.org/jdk/pull/10411