RFR: 8293691: converting a defined BasicType value to a string should not crash the VM

[Johan Sjölen]

On Tue, 27 Sep 2022 12:14:04 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Hi,
>> 
>> This implements Kim's suggested fix for this ticket.
>
> src/hotspot/share/utilities/globalDefinitions.cpp line 240:
> 
>> 238: };
>> 239: const char* type2name(BasicType t) {
>> 240:   if (t < (T_CONFLICT + 1)) {
> 
> Looks cleaner to do `if (t <= T_CONFLICT)`, maybe?

Hm, yeah. This looks like this to create symmetry with the declaration of `type2name_tab`:


extern const char* type2name_tab[T_CONFLICT+1];     // Map a BasicType to a char*


But the symmetry is lost here as they're in 2 different files now. I'd like a RFE where `type2name_tab` is no longer external which will make the symmetry apparent again. Can we ignore this nit in anticipation of that change?

-------------

PR: https://git.openjdk.org/jdk/pull/10447