RFR: 8305509: C1 fails "assert(k != nullptr) failed: illegal use of unloaded klass"

Tue Apr 4 16:06:06 UTC 2023

On Tue, 4 Apr 2023 14:32:42 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

> I tested the fix for JDK-8304743 on tier1-8, then did this refactoring which required a ciKlass::get_Klass() call that failed.  This fix reverts the refactoring.
> 
> Here was the commit for JDK-8304743: https://github.com/openjdk/jdk/commit/b062b1bd8126610d9288dc179d69e54a40b81015
> 
> I added the HandleMark to the utility function.  It wasn't there in the original code.
> 
> Tested with tier4.

I agree that this this patch is a clean reversion of the refactoring
changes made in the https://github.com/openjdk/jdk/pull/13270 PR.
So this work returns the state of this patch to where you did Mach5
Tier[1-8] testing.

You didn't declare this fix to be trivial, but I consider this to be a
trivial [BACKOUT] of a portion of the fix for:

[JDK-8304743](https://bugs.openjdk.org/browse/JDK-8304743) Compile_lock and SystemDictionary updates

-------------

Marked as reviewed by dcubed (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/13327#pullrequestreview-1371317979