RFR: 8302328: [s390x] Simplify asm_assert definition [v2]

[Lutz Schmidt]

On Wed, 29 Mar 2023 16:56:42 GMT, Amit Kumar <amitkumar at openjdk.org> wrote:

>> src/hotspot/cpu/s390/stubRoutines_s390.cpp line 58:
>> 
>>> 56:     __ z_cgr(table, Z_R0);  // safety net
>>> 57:     __ z_bre(L);
>>> 58:     __ asm_assert(Assembler::bcondEqual, "crc_table: external word relocation required for load_absolute_address", 0x33);
>> 
>> How should this `asm_assert` ever get hit? It's preceded by a `bre.`
>
> This was requested change (initially it was not part of this PR).

The request was to "move z_illtrap() after asm_assert()". For debug builds, you then get a descriptive assert message. For release builds, you at least have a security net.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/12822#discussion_r1165506536