RFR: 8302328: [s390x] Simplify asm_assert definition [v2]
Martin Doerr
mdoerr at openjdk.org
Thu Apr 13 13:42:38 UTC 2023
On Thu, 13 Apr 2023 13:15:49 GMT, Lutz Schmidt <lucy at openjdk.org> wrote:
>> This was requested change (initially it was not part of this PR).
>
> The request was to "move z_illtrap() after asm_assert()". For debug builds, you then get a descriptive assert message. For release builds, you at least have a security net.
`z_bre` + `asm_assert(Assembler::bcondEqual, ...` still doesn't make sense to me.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/12822#discussion_r1165538813
More information about the hotspot-dev
mailing list