RFR: 8302328: [s390x] Simplify asm_assert definition [v2]
Martin Doerr
mdoerr at openjdk.org
Thu Apr 13 16:36:07 UTC 2023
On Thu, 13 Apr 2023 15:12:55 GMT, Lutz Schmidt <lucy at openjdk.org> wrote:
>> Seems like you didn't get my point. The `z_bre` is fine, but the assert condition "bcondEqual" can't be true after that. The asm_assert should be unconditional.
>
> Arrgh! You are right. Using the inverse condition (bcondNotEqual) is a better choice.
What about using `stop` or anything which doesn't take a condition? That would avoid confusion.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/12822#discussion_r1165779006
More information about the hotspot-dev
mailing list