RFR: 8302328: [s390x] Simplify asm_assert definition [v2]

Thu Apr 13 15:15:39 UTC 2023

On Thu, 13 Apr 2023 14:22:07 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

>> z_bre is a "branch if equal". Everything is fine if both registers contain the same value. Otherwise, there is something wrong.
>
> Seems like you didn't get my point. The `z_bre` is fine, but the assert condition "bcondEqual" can't be true after that. The asm_assert should be unconditional.

Arrgh! You are right. Using the inverse condition (bcondNotEqual) is a better choice.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/12822#discussion_r1165683269