RFR: 8300197: Freeze/thaw an interpreter frame using a single copy_to_chunk() call
Fredrik Bredberg
duke at openjdk.org
Mon Apr 17 19:16:10 UTC 2023
On Mon, 17 Apr 2023 14:41:23 GMT, Richard Reingruber <rrich at openjdk.org> wrote:
>> I see what you mean, but I chose to keep it because of the assert() in ThawBase::set_interpreter_frame_bottom.
>> After all, it was this assert that alerted me to the JDK-8305247 bug.
>
> Is it possible to get an equivalent but platform independent version of the assertion?
> Something like `assert(f.interpreter_frame_local_at(0) == stack_frame_bottom - 1, "");` might work.
> It could replace the call of `set_interpreter_frame_bottom()`.
> After all with this pr no platform will ever have to actually set the interpreter frame bottom so it would be good to at least rename the method.
Sounds like a plan. I'll look into it.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13477#discussion_r1169174223
More information about the hotspot-dev
mailing list