RFR: 8300197: Freeze/thaw an interpreter frame using a single copy_to_chunk() call [v2]
Fredrik Bredberg
duke at openjdk.org
Fri Apr 21 13:19:55 UTC 2023
On Mon, 17 Apr 2023 19:13:33 GMT, Fredrik Bredberg <duke at openjdk.org> wrote:
>> Is it possible to get an equivalent but platform independent version of the assertion?
>> Something like `assert(f.interpreter_frame_local_at(0) == stack_frame_bottom - 1, "");` might work.
>> It could replace the call of `set_interpreter_frame_bottom()`.
>> After all with this pr no platform will ever have to actually set the interpreter frame bottom so it would be good to at least rename the method.
>
> Sounds like a plan. I'll look into it.
Replaced the call to `set_interpreter_frame_bottom` in `ThawBase::recurse_thaw_interpreted_frame` with:
`assert(f.interpreter_frame_local_at(0) == stack_frame_bottom - 1, "invalid frame bottom");
`Then removed the `set_interpreter_frame_bottom` method from all platforms.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13477#discussion_r1173751267
More information about the hotspot-dev
mailing list