RFR: 8300197: Freeze/thaw an interpreter frame using a single copy_to_chunk() call [v2]

[Fredrik Bredberg]

On Mon, 17 Apr 2023 10:05:10 GMT, Richard Reingruber <rrich at openjdk.org> wrote:

>> Fredrik Bredberg has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Updated after review
>
> src/hotspot/cpu/ppc/continuationFreezeThaw_ppc.inline.hpp line 267:
> 
>> 265:   intptr_t *sp, *fp;
>> 266:   if (FKind::interpreted) {
>> 267:     intptr_t offset = *f.addr_at(ijava_idx(locals));
> 
> I'd prefer a more specific name. Maybe `locals_offset` or `local0_offset`?

Changed the name to `locals_offset` (in all platforms).

> src/hotspot/share/runtime/continuationFreezeThaw.cpp line 1092:
> 
>> 1090:   assert(heap_frame_bottom == heap_frame_top + fsize, "");
>> 1091: 
>> 1092:   // Some architectures (like AArch64/PPC64/RISC-V) adds padding between the locals and the fixed_frame to keep the fp 16-byte-aligned.
> 
> Typo
> Suggestion:
> 
>   // Some architectures (like AArch64/PPC64/RISC-V) add padding between the locals and the fixed_frame to keep the fp 16-byte-aligned.

Fixed

> src/hotspot/share/runtime/continuationFreezeThaw.cpp line 2156:
> 
>> 2154:   assert(!f.is_heap_frame(), "should not be");
>> 2155: 
>> 2156:   // Some architectures (like AArch64/PPC64/RISC-V) adds padding between the locals and the fixed_frame to keep the fp 16-byte-aligned.
> 
> Suggestion:
> 
>   // Some architectures (like AArch64/PPC64/RISC-V) add padding between the locals and the fixed_frame to keep the fp 16-byte-aligned.

Fixed

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13477#discussion_r1173753626
PR Review Comment: https://git.openjdk.org/jdk/pull/13477#discussion_r1173755462
PR Review Comment: https://git.openjdk.org/jdk/pull/13477#discussion_r1173756029