RFR: 8300197: Freeze/thaw an interpreter frame using a single copy_to_chunk() call [v2]
Fredrik Bredberg
duke at openjdk.org
Fri Apr 21 13:39:50 UTC 2023
On Mon, 17 Apr 2023 10:01:15 GMT, Richard Reingruber <rrich at openjdk.org> wrote:
>> Fredrik Bredberg has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Updated after review
>
> src/hotspot/cpu/ppc/continuationFreezeThaw_ppc.inline.hpp line 510:
>
>> 508: // we need to set the locals so that the caller of new_stack_frame() can call
>> 509: // ContinuationHelper::InterpretedFrame::frame_bottom
>> 510: // copy relativized locals from the heap frame
>
> Maybe reduce the comment?
>
> // we need to copy the locals so that the caller of new_stack_frame() can call
> // ContinuationHelper::InterpretedFrame::frame_bottom
I think the comment is good as it is, because it describes just why we need to set the locals this early (and not the rest of the members in the fixed_frame).
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13477#discussion_r1173778601
More information about the hotspot-dev
mailing list