RFR: 8300197: Freeze/thaw an interpreter frame using a single copy_to_chunk() call [v2]
Fredrik Bredberg
duke at openjdk.org
Fri Apr 21 13:23:50 UTC 2023
On Mon, 17 Apr 2023 19:02:12 GMT, Patricio Chilano Mateo <pchilanomate at openjdk.org> wrote:
>> Fredrik Bredberg has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Updated after review
>
> src/hotspot/share/runtime/continuationFreezeThaw.cpp line 2152:
>
>> 2150:
>> 2151: assert((stack_frame_bottom >= stack_frame_top + fsize) &&
>> 2152: (stack_frame_bottom <= stack_frame_top + fsize + 1), ""); // internal alignment on aarch64
>
> Since we didn't add any new padding shouldn't this assert now be stack_frame_bottom == stack_frame_top + fsize?
Your're right @pchilano, it should. But since the line just above is:
`const int fsize = heap_frame_bottom - heap_frame_top;`
I thought that there was no use in keeping the `assert` at all, so I removed it.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13477#discussion_r1173760286
More information about the hotspot-dev
mailing list