RFR: 8300197: Freeze/thaw an interpreter frame using a single copy_to_chunk() call [v2]

[Patricio Chilano Mateo]

On Fri, 21 Apr 2023 13:21:15 GMT, Fredrik Bredberg <duke at openjdk.org> wrote:

>> src/hotspot/share/runtime/continuationFreezeThaw.cpp line 2152:
>> 
>>> 2150: 
>>> 2151:   assert((stack_frame_bottom >= stack_frame_top + fsize) &&
>>> 2152:          (stack_frame_bottom <= stack_frame_top + fsize + 1), ""); // internal alignment on aarch64
>> 
>> Since we didn't add any new padding shouldn't this assert now be stack_frame_bottom == stack_frame_top + fsize?
>
> Your're right @pchilano, it should. But since the line just above is:
> `const int fsize = heap_frame_bottom - heap_frame_top;`
> I thought that there was no use in keeping the `assert` at all, so I removed it.

Yes, but it's comparing it with the created stack frame's size so I think it doesn't hurt to keep it. We have an equivalent assert in recurse_freeze_interpreted_frame().

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13477#discussion_r1173943088