RFR: JDK-8305387: JDK-8301995 breaks arm 32-bit

[Andrew Haley]

On Sat, 22 Apr 2023 06:54:59 GMT, Aleksei Voitylov <avoitylov at openjdk.org> wrote:

> Provides missing implementation for arm32.
> 
> Testing: hotspot/jtreg.

Looks fine, except for one small not.

src/hotspot/cpu/arm/templateTable_arm.cpp line 2639:

> 2637:   // Update registers with resolved info
> 2638:   __ load_resolved_indy_entry(cache, index);
> 2639:   // Load-acquire the adapter method to match store-release in ResolvedIndyEntry::fill_in()

I'm confused by this comment. `MacroAssembler::LoadLoad` is not an acquire barrier, although I guess it must be one, because `DMB LD` will be emitted. To match the release in `ResolvedIndyEntry::fill_in()` this should be `LoadLoad|LoadStore`.

-------------

PR Review: https://git.openjdk.org/jdk/pull/13596#pullrequestreview-1396708437
PR Review Comment: https://git.openjdk.org/jdk/pull/13596#discussion_r1174393011