RFR: JDK-8305387: JDK-8301995 breaks arm 32-bit [v2]

[Aleksei Voitylov]

On Sat, 22 Apr 2023 11:38:04 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> Aleksei Voitylov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   address review comments
>
> src/hotspot/cpu/arm/templateTable_arm.cpp line 2639:
> 
>> 2637:   // Update registers with resolved info
>> 2638:   __ load_resolved_indy_entry(cache, index);
>> 2639:   // Load-acquire the adapter method to match store-release in ResolvedIndyEntry::fill_in()
> 
> I'm confused by this comment. `MacroAssembler::LoadLoad` is not an acquire barrier, although I guess it must be one, because `DMB LD` will be emitted. To match the release in `ResolvedIndyEntry::fill_in()` this should be `LoadLoad|LoadStore`.

Fixed, thanks for catching this. Note that currently DMB SY is emitted either way, but it's important to keep semantic consistent.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13596#discussion_r1174996181