RFR: 8300197: Freeze/thaw an interpreter frame using a single copy_to_chunk() call [v2]

Fredrik Bredberg duke at openjdk.org
Mon Apr 24 09:42:47 UTC 2023


On Mon, 17 Apr 2023 10:19:25 GMT, Richard Reingruber <rrich at openjdk.org> wrote:

>> Fredrik Bredberg has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Updated after review
>
> src/hotspot/share/runtime/continuationFreezeThaw.cpp line 1093:
> 
>> 1091: 
>> 1092:   // Some architectures (like AArch64/PPC64/RISC-V) adds padding between the locals and the fixed_frame to keep the fp 16-byte-aligned.
>> 1093:   // On those architectures we freeze the padding in order to keep the same localized pointer values.
> 
> Suggestion:
> 
>   // On those architectures we freeze the padding in order to keep the same relative references.

Tried to clarify by changing the comment to:
`// On those architectures we freeze the padding in order to keep the same fp-relative offsets in the fixed_frame.`

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13477#discussion_r1175034185


More information about the hotspot-dev mailing list